fix: bypass Qt's QFile::encodeName() in csync #12039
Open
+197
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjv
force-pushed
the
fix/no-normalization-macos
branch
from
849a1ca to
1b2d2ca
Compare
DeepDiver1975
force-pushed
the
fix/no-normalization-macos
branch
3 times, most recently
from
a70dda3 to
980bd4a
Compare
|
I moved "Clarify propagator job descriptions" out as a seperate PR: #12050 . We can merge the |
erikjv
force-pushed
the
fix/no-normalization-macos
branch
2 times, most recently
from
a74d10d to
44b4a8c
Compare
DeepDiver1975
commented
Jan 30, 2025
test/testlocaldiscovery.cpp
Outdated
|
|
||
| // Test that when a file/directory name on the remote is encoded in NFC, the local name is encoded | ||
| // in the same way, and that a subsequent sync does not change anything. And the same for NFD. | ||
| void testNameEncoding() |
There was a problem hiding this comment.
@erikjv Please document what exactly this test is about. Also thinking about that the function name testNameEncoding() is not giving that much of an explanation. THX
DeepDiver1975
force-pushed
the
fix/no-normalization-macos
branch
from
44b4a8c to
a609ad5
Compare
erikjv
force-pushed
the
fix/no-normalization-macos
branch
from
a609ad5 to
ca99d6b
Compare
erikjv
force-pushed
the
fix/no-normalization-macos
branch
2 times, most recently
from
ab3e219 to
4504d25
Compare
…File::encodeName()
To prevent `QFile::rename` doing normalization changes to the file name.
Check that a file/directory name with NFC encoding on the server ends up with the same encoding on the client, and that a subsequent discovery+sync will not upload differently encoded files. Same for an NFD encoded file/directory name.
erikjv
force-pushed
the
fix/no-normalization-macos
branch
from
4504d25 to
f978da9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToDo